I first saw this in a history class. You kind of want to laugh at happy images of Hitler, sort of like you want to laugh during scenes of the Exorcist.
She did other films that weren't quite as Nazi-fied that were also very good on a technical level. I also recommend the movie "The Wonderful Horrible Life of Leni Riefenstahl" to anyone remotely interested in her.